Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Popper.js to 1.12.3 #23626

Merged
merged 2 commits into from
Aug 23, 2017
Merged

Update Popper.js to 1.12.3 #23626

merged 2 commits into from
Aug 23, 2017

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Aug 22, 2017

Update Popper.js with the first non-broken NuGet version of Popper.js

Fixes #23622

@jipexu
Copy link
Contributor

jipexu commented Aug 22, 2017

Hi
with this version of popper i got js error on console ...
please see at this
floating-ui/floating-ui#398

but i can not reproduce in code pen ..

Any idea ?

@XhmikosR
Copy link
Member

I can't comment on the update itself since I haven't been following popper.js's development, so if you test and everything is good we are fine.

One thing I'd change is to use the Jekyll config variable. So if you agree and everything is good merge after that @Johann-S

@Johann-S
Copy link
Member Author

Is it possible to create a Codepen with Bootstrap @jipexu ?
I'll try to do some more test today before merging this PR
and thanks @XhmikosR that's a very good change 👍

@jipexu
Copy link
Contributor

jipexu commented Aug 23, 2017

hi @Johann-S no i tried but i can not see on codepen console ...
to see is simple juste create some element with attribut title and data-toggle="tooltip" ...
on hover if some value of the title attribut are empty in html we get the error in the browser console
i will try again to see this in code pen.... Thanks

@jipexu
Copy link
Contributor

jipexu commented Aug 23, 2017

many sorry i was wrong i used data-placement="top-start" so i got this error :-(

@Johann-S
Copy link
Member Author

So everything is fine 😃 I'll merge this one or @XhmikosR it seems he is present 😆

@XhmikosR XhmikosR merged commit 3a6fc26 into v4-dev Aug 23, 2017
@XhmikosR XhmikosR deleted the v4-popper branch August 23, 2017 07:44
@ghost ghost mentioned this pull request Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants